-
Notifications
You must be signed in to change notification settings - Fork 141
Logit warpers #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logit warpers #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great PR! 🙌 Super unfortunate that both @mattt and you worked on this at the same time.
Sources/Generation/LogitsWarper/RepetitionPenaltyLogitsProcessor.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for iterating, Kashif, and for double-checking the ordering 🙌
This looks ready to merge, will wait a few hours in case anyone has comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kashif!
fixes issue #271