Skip to content

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Sep 28, 2025

fixes issue #271

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great PR! 🙌 Super unfortunate that both @mattt and you worked on this at the same time.

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for iterating, Kashif, and for double-checking the ordering 🙌

This looks ready to merge, will wait a few hours in case anyone has comments.

Copy link
Collaborator

@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kashif!

@pcuenca pcuenca merged commit 4870d18 into huggingface:main Sep 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants